./build.sh | grep +failed | wc -l
0

At least "Works on my system" (tm)

Also that new commit fixes the scripts to work regardless of cwd

Oh, I bet I can do this
Closes #8

I removed the patrol files in an explicit commit. Please rebase this patch series on top of master.

In general, each change you make that can stand alone should be in its own commit, even if submitted in the PR as a chunk.

Put the comment Closes #8 in the top patch of the PR

Yeah, I think I needed to put that new commit in another branch, right?

No, you can force update your existing branch and it will update.

On Thu, Dec 27, 2018, 12:39 PM Sean Pryor <pagure@pagure.io wrote:

xaenalt commented on the pull-request: Updated roles to global/project, also changed reader to auditor that you are following:
Yeah, I think I needed to put that new commit in another branch, right?

To reply, visit the link below or just reply to this email
https://pagure.io/openstack-access-policy/pull-request/10

Right, but force updating a second commit on top of this one wouldn't create a separate PR apparently

Exactly. It would update this pr. Please do so.

On Thu, Dec 27, 2018, 7:33 PM Sean Pryor <pagure@pagure.io wrote:

xaenalt commented on the pull-request: Updated roles to global/project, also changed reader to auditor that you are following:
Right, but force updating a second commit on top of this one wouldn't create a separate PR apparently

To reply, visit the link below or just reply to this email
https://pagure.io/openstack-access-policy/pull-request/10

Ok, I did the rebase and stuff onto master, was there anything else I needed to do?