#1431 setup has many static uids and gids that are not listed in https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/
Closed: Fixed by james. Opened by adamwill.

edit: this issue was initially reported about bind, but now I look, there's actually a huge delta between https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_list_of_statically_allocated_uidgid_and_corresponding_package and https://src.fedoraproject.org/rpms/setup/blob/rawhide/f/uidgid , so let's make this a general issue.

There are a ton of static UIDs and GIDs in https://src.fedoraproject.org/rpms/setup/blob/rawhide/f/uidgid that are not listed at https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_list_of_statically_allocated_uidgid_and_corresponding_package . This is confusing (at least, it confused me). Does that list need to be updated, or should it be removed and replaced with simply a link to the uidgid file? Is FPC aware of and OK with all the statically-allocated UIDs and GIDs in that file?

Several of the ones missing in the doc have been around since 2008 or 2009, like named and pkiuser. Some are newer, like GID 101 for ssh_keys or UID/GID 114 for polkitd. The setup package changelog went through a phase where new additions linked to an FPC ticket, but before and after that phase are many new additions which didn't link to an FPC ticket:

[adamw@toolbx setup (rawhide)]$ grep uidgid changelog 
- uidgid: assign GID 101 for 'ssh_keys' group
- uidgid: assign UID/GID 114 for 'polkitd'
- uidgid: simplify table format and other format enhancements
- uidgid: fix news and lock entries, move basic groups to systemd
- fix homedirs and shells for several users in uidgid file (#1190321)
- assign uidgid for cassandra(143:143) - (FPC #628)
- assign uidgid for ceph(167:167) - FPC 524,bz#1220846
- assign uidgid for systemd-network(192:192) - FPC 481,bz#1102002
- assign uidgid for systemd-resolve(193:193) - FPC 481,bz#1102002
- remove uidgid reservation for systemd-journal-gateway (#1174304)
- reserve uidgid pair 142:142 for activemq (#1070881)
- assign 166:166 uidgid pair for ceilometer (#923891)
- drop uucp (uidgid 14) from groups created by default
- assign 191:191 uidgid pair for systemd-journal-gateway (#918120)
- assign 165:165 uidgid pair for cinder (#902987)
- rename rhevagent uidgid reservation to ovirtagent
- reserve 181:181 uidgid pair for wallaby (#772747)
...etc

[comment merged into initial edited description]

Yeh, I'll bring it up at the meeting and ask everyone for opinions but there's def. some "who really owns this" so I'm not shocked by "The setup package changelog went through a phase where new additions linked to an FPC ticket, but before and after that phase are many new additions which didn't link to an FPC ticket"

Metadata Update from @james:
- Issue tagged with: meeting

Since I think that keeping this list in two places is bound to lead to things getting out of sync, I suggested during the meeting that it might be a better idea to just document the uidgid file in setup as the canonical source for this list, and remove it from the docs - but keeping the requirement that new static UID / GID allocations MUST go through FPC.

If that is done, it would probably be good to also document this in the setup package somehow. Not sure if this file format allows comments, but adding one at the top saying "don't add new stuff here without FPC approval" should do it (if that's possible).

We have some kind of PR, but it does a bunch of non-documentation things that are on hold. Hopefully we can get incremental improvements.

https://pagure.io/packaging-committee/pull-request/1436

Commit 83929538 fixes this issue

Metadata
Related Pull Requests