python-daemon

#55 twine is not a build dependency
Closed: Fixed by bignose. Opened by jandryuk.

Closed: Fixed
Reopen Issue

twine isn't a build dependency - it is only a needed to upload to PyPI. python-daemon builds and runs without twine. twine has a large dependency tree which pulls in many other packages unneeded for a local build.

https://pagure.io/python-daemon/pull-request/47 was an attempt to move twine from build to a development dependency.

For an openembedded-based build, I just patched out the twine dependency to avoid having to package up lots of other otherwise unneeded packages. https://github.com/OpenXT/xenclient-oe/commit/f38de5638ad45070eff70b1be3ed2aaae6b064e1

Metadata Update from @bignose:
- Issue tagged with: more-info

Thanks, Jason.

@jameshilliard As the person who proposed the change (in https://pagure.io/python-daemon/pull-request/47 merge request 47), what is the motivation for this? How can we achieve this without obliging a Twine download on users that don't need or want it?
Edited by bignose

what is the motivation for this

Same as for @jandryuk except I hit this issue for buildroot instead of openembedded.

How can we achieve this without obliging a Twine download on users that don't need or want it?

Make sure it is not present in setup_requires like I did in https://pagure.io/python-daemon/pull-request/47 I don't see that change actually incorporated in main or master, was it only in a temporary release branch?

@jameshilliard:

Make sure it is not present in setup_requires like I did in https://pagure.io/python-daemon/pull-request/47 I don't see that change actually incorporated in main or master, was it only in a temporary release branch?

I'm not sure what happened there. I have now incorporated those changes into the 'main' branch at commit 5a24d22b, please check whether this is correct.
Edited by bignose

@jameshilliard:

Make sure it is not present in setup_requires like I did in https://pagure.io/python-daemon/pull-request/47 I don't see that change actually incorporated in main or master, was it only in a temporary release branch?

I'm not sure what happened there. I have now incorporated those changes into the 'main' branch at commit 5a24d22b, please check whether this is correct.

Yeah, seems to be showing up now.

@jameshilliard:

@bignose:

I have now incorporated those changes into the 'main' branch at commit 5a24d22b, please check whether this is correct.

Yeah, seems to be showing up now.

Thanks. Can you get the source from 'main' and confirm this corrects the issue:
- Building the package should not introduce Twine as a dependency.
- Using Twine (from the Make build system) should automatically install Twine as needed.
Edited by bignose

@jameshilliard:

@bignose:

I have now incorporated those changes into the 'main' branch at commit 5a24d22b, please check whether this is correct.

Yeah, seems to be showing up now.

Thanks. Can you get the source from 'main' and confirm this corrects the issue:
- Building the package should not introduce Twine as a dependency.

Confirmed that python-daemon build now works as expected on 'main'.

  • Using Twine (from the Make build system) should automatically install Twine as needed.

We don't support twine in buildroot.

Metadata Update from @bignose:
- Issue untagged with: more-info

I have now incorporated those changes into the 'main' branch at commit 5a24d22b, please check whether this is correct.

Thanks to @jameshilliard for testing. These changes are now incorporated into release 2.3.2, correcting this issue.

Metadata Update from @bignose:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.