python-daemon

#24 Refactor testing by introducing tox.
Closed by bignose. Opened by hberaud.
hberaud/python-daemon refactor-tests  into  master

Download 24.patch

Since we have propose to refactor the project
release management by using pbr we now propose with this
commit to refactor testing by using tox[1].

Why using tox? tox introduce virtualenv for testing
and allow to test your project with multiple version
of python in the same time. Also tox is a standard tools
in python community and made the testing more straightforward
for your contributors and maintainers.

This commit introduce:
- introduce requirements file for tests dependancies;
- remove PEP 518 since pbr was introduced and your pyproject.toml was incompatible with tox;
- improve hacking doc by explain to your contributors how to test theirs changes.

Using it:
- install tox (pip install tox);
- launch tests (tox)

tox[1] allow simplify python testing by introducing:
- virtualenv;
- specific targets;
- cross testing;
- integrated with many CI platforms.

In order merge this pull request before => https://pagure.io/python-daemon/pull-request/23

[1] https://tox.readthedocs.io/en/latest/

Co-authored-by: Hobbestigrou hobbestigrou@erakis.eu

rebased onto 99324f5c1bea4d48279a9bae13d02a9add52f710

Please be careful to merge these pull requests in order:

  1. 23

  2. 24

  3. 25

  4. 26

Thank you

Thank you for this suggestion, I will look through it.

You have included this change:

remove PEP 518 since pbr was introduced and your pyproject.toml was incompatible with tox

Is that a bug in Tox? Or a problem wih the pyproject.toml file?

I would prefer either of those being corrected, not removing the file.

This file was added in order to support systems that use it. Why remove it?

If there is a problem in this file, I would like to fix the file and keep its functionality intact.

If there is a problem with some third-party system (e.g. Tox), that does not seem good enough reason to remove this file.

Thanks for the suggestion. I have implemented this differently, by:

  • Fixing a bug in the pyproject.toml file.
  • Implementing Pip requirements declarations for different purposes.
  • Configuring Tox for the project.

Pull-Request has been closed by bignose
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.