#7 Closes #5 DaemonRunner.py fails on python 3.x systems (unbuffered text i/o).
Closed by bignose. Opened by denistrofimov.
denistrofimov/python-daemon master  into  master

Download 7.patch
no initial comment

Python 3.5 Centos testing in a virtualenv on my preproduction.

Thanks for working on this.

I'll need to see these different conditions exercised by unit tests, to be sure (in automated tests) it works on different Python versions.

Is there some more specific way to do this, maybe by using a type that will work without error on any Python version?

Is there some more specific way to do this, maybe by using a type that will work without error on any Python version?
A way like it is here

self.daemon_context.stderr = open(app.stderr_path, 'w+')

2 new commits added

  • Merge branch 'master' of ssh://pagure.io/forks/denistrofimov/python-daemon
  • Closes #5 DaemonRunner.py fails on python 3.x systems (unbuffered text i/o).

in one word I did it typeless!?

What is the reason to remove the ‘buffering’ argument?

Can this be done in a compatible way, without just removing that argument?

Have you exercised these changes in unit tests, on Python 2 and Python 3? What changes are needed to the unit tests to ensure this works compatibly?

Metadata Update from @bignose:
- Pull-request tagged with: moreinfo

The example runner module is now deprecated. It will be removed in a future version of this library.

Pull-Request has been closed by bignose

Metadata