#81 Changed deprecated lockfile by filelock
Opened by l98peyro. Modified
l98peyro/python-daemon change-pidlockfile-by-filelock  into  main

Download 81.patch

Related to #42 Dependency "lockfile" is deprecated
Last update of lockfile was at Nov 25, 2015 (version 0.12.2).

Thank you for making this merge request.

I have been considering the 'pid' package instead https://pypi.org/project/pid/ — can you explain the differences, and why you've chosen 'filelock' instead?

Please leave this blank line in place; it helps the code formatting conform to PEP 8.

How do these statements help this custom class? Are these not the defaults for filelock.FileLock, or have I misunderstood?

It would be good to see an entry in the ChangeLog document, explaining the transition from one dependency to the other.

See earlier in the ChangeLog document for examples; you would make a new "Bugs fixed" entry under "Version NEXT", I think.

Please see the PEP 8 guidance on how to separate import statements in a module.
The groupings (separated each by a blank line) should be:

  • __future__ imports; then
  • Standard library imports; then
  • Third-party library imports; then
  • Local imports.

Now that python-daemon has dropped support for Python earlier than version 2, we can probably omit the explicit inheritance from object. Does the code continue to work (and pass tests) without that?

Thank you for updating the test cases.

Please be sure to go through all the docstrings everywhere and change references to lockfile (and other corresponding names that have changed), which are now outdated.

Metadata Update from @bignose:
- Request assigned

1 new commit added

  • Updated changelog, and removed useless declarations in pidfile

2 new commits added

  • Updated changelog, and removed useless declarations in pidfile
  • Changed deprecated lockfile by filelock

rebased onto 334f458ee5508c3890e9da6baacd5470868abcd9

rebased onto a38a18a77c67cd23d35a15eb74fedbfc91fed725

Any update?

Metadata