#11449 Bugs not closed after update is pushed to stable
Closed: It's all good by gui1ty. Opened by gui1ty.

Has there been an issue with updating bugs after an update has been pushed to stable?

The associated bugs with the following updates are still on status ON_QA. The expected comments have been added to the bugs, but they were not closed.

https://bodhi.fedoraproject.org/updates/FEDORA-2023-328397d034
https://bodhi.fedoraproject.org/updates/FEDORA-2023-cc571303eb


The first one FEDORA-2023-328397d034 had the close_bugs property set to off, so while comments are posted, the bugs were not closed.
As for the second FEDORA-2023-cc571303eb I see that the attached bugs were properly closed.

The first one FEDORA-2023-328397d034 had the close_bugs property set to off, so while comments are posted, the bugs were not closed.

I see. Or rather I don't. :wink:
I looked in the web UI and I cannot see which options were used when submitting the update.
I thought closing bugs is the default, if an updates has bugs linked. At least that's my experience using fedpkg update. This update was submitted using the web UI.

As for the second FEDORA-2023-cc571303eb I see that the attached bugs were properly closed.

My bad. I saw a lot of Bottles bugs still in ON_QA and assumed that both updates failed to close bugs.

The first one FEDORA-2023-328397d034 had the close_bugs property set to off, so while comments are posted, the bugs were not closed.

I see. Or rather I don't. :wink:
I looked in the web UI and I cannot see which options were used when submitting the update.
I thought closing bugs is the default, if an updates has bugs linked. At least that's my experience using fedpkg update. This update was submitted using the web UI.

Yes, the update page in the GUI doesn't have a visual representation of that setting. I'll mark that feature for a future bodhi upgrade.
Meanwhile the way to check that is in the edit page (which is no more an option when an update has already went to stable) or retrieving the json representation of the update. You can do the later by changing the Accept request header in the browser to application/json (there are some browser plugins that let you do this), or using something else (python, javascript).
And, yes, the default is to close bugs, so maybe while submitting the update in the web UI you mistakenly changed the flag.

Thanks for the explanation. I closed the bugs meanwhile. Closing this ticket now.

Metadata Update from @gui1ty:
- Issue close_status updated to: It's all good
- Issue status updated to: Closed (was: Open)

Metadata