• Describe the issue
  The spam-o-matic script still exists and is called by at least the Rawhide nightly compose script. However, pungi also has the repoclosure phase, which produces effectively the same report using dnf repoclosure.

spam-o-matic outputs to logs/depcheck, and generates a single report for the compose; the way we use it for Rawhide, it always runs against the Everything variant. repoclosure phase outputs to logs/<arch>/repoclosure-<variant>-<arch>.log, and creates one report per variant (that contains a package repo) per arch.

spam-o-matic uses the older DNF Python bindings from dnf3/4 which are intended to go away at some point (though probably not any time soon). repoclosure is a core dnf5 plugin and so is maintained by the dnf devs and should remain up to date.

I can see two benefits of spam-o-matic: its report is arguably a bit more readable (it groups errors from the same source RPM together, and it's more concise, repoclosure includes the repo the package is from which is not interesting to us), and it is capable of emailing the package maintainers to nag them to fix the bug.

We have not had the email functionality enabled for Rawhide since d436118d7fe3c7265800e9748d726364710221c9 in Feb 2018, when we turned it off because it didn't handle rich deps properly (it still doesn't; repoclosure doesn't either, but I've sent https://github.com/rpm-software-management/dnf5/pull/2291 as a workaround).

I can see two options here:

1) Decide that, since we haven't had the nag mails for 8 years, we can probably live without them. Just drop spam-o-matic use and kill it
2) Rewrite spam-o-matic as just a parser of the repoclosure output, which figures out the source package for each package with an error, and emails the owner. It could also output an arch-combined report in a modified format like the one it currently outputs, I guess

• When do you need this? No particular date

• When is this no longer needed or useful? When Konflux eats the world

• If we cannot complete your request, what is the impact? We'll continue to have two tools doing more or less the same thing on Rawhide composes (but not any other compose - all the others have repoclosure phase logs but not spam-o-matic, AFAIK)