releng

#9089 remove tag2distrepo on coreos-pool tag
Closed: Fixed by mohanboddu. Opened by dustymabe.

Closed: Fixed
Reopen Issue

For now we are working around https://pagure.io/koji/issue/1630 by running distrepo manually. See https://github.com/coreos/fedora-coreos-releng-automation/issues/52.

Can we get the tag2distrepo functionality disabled for the coreos-pool tag in prod and staging?

As part of this we would really like to keep the list of tag2distrepo.keys associated with the tag:

Tag: coreos-pool [8632]
Arches: aarch64 ppc64le s390x x86_64
Groups: 
Tag options:
  tag2distrepo.enabled : 'true'
  tag2distrepo.keys : '429476b4 cfc659b9 3c3359c4 12c944d0'
Inheritance:

We are re-using that information in our logic for calling distrepo.

Done.

$ koji taginfo coreos-pool                          2068ms < Tue 10 Dec 2019 10:46:04 AM EST
Tag: coreos-pool [8632]
Arches: aarch64 ppc64le s390x x86_64
Groups: 
Tag options:
  tag2distrepo.enabled : 'false'
  tag2distrepo.keys : '429476b4 cfc659b9 3c3359c4 12c944d0'
Inheritance:
$ stg-koji taginfo coreos-pool                      1560ms < Tue 10 Dec 2019 10:46:14 AM EST
Tag: coreos-pool [7716]
Arches: aarch64 ppc64le s390x x86_64
Groups: 
Tag options:
  tag2distrepo.enabled : 'false'
  tag2distrepo.keys : 'd300e724'
Inheritance:

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

What Mohan did above didn't quite work because the code has:

    if not tag['extra'].get("tag2distrepo.enabled"):                                                                                                                                                                                         
        logger.debug("No tag2distrepo enabled for tag %s" % tag['name'])

which means a string of 'false' will still evaluate to True.

He modified it such that tag2distrepo.enabled is gone:

[dustymabe@toolbox ~]$ koji taginfo coreos-pool
Tag: coreos-pool [8632]
Arches: aarch64 ppc64le s390x x86_64
Groups: 
Tag options:
  tag2distrepo.keys : '429476b4 cfc659b9 3c3359c4 12c944d0'
Inheritance:
[dustymabe@toolbox ~]$ stg-koji taginfo coreos-pool
Tag: coreos-pool [7716]
Arches: aarch64 ppc64le s390x x86_64
Groups: 
Tag options:
  tag2distrepo.keys : 'd300e724'
Inheritance:

One random thought on this, rather than reusing the tag2distrepo.keys option, we might want our own e.g. coreos-koji-tagger.keys option. That'll make it more clear what's using it and reduce the likelihood of someone nuking that option since tag2distrepo is clearly not enabled.

One random thought on this, rather than reusing the tag2distrepo.keys option, we might want our own e.g. coreos-koji-tagger.keys option. That'll make it more clear what's using it and reduce the likelihood of someone nuking that option since tag2distrepo is clearly not enabled.

I was thinking that we'd go back to using tag2distrepo once the race condition was fixed (seems in progress). Though if we prefer not using tag2distrepo then I think I agree with you. Though we could just maintain the list inside of coreos-koji-tagger itself at that point.

WDYT?
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.