From 7dfee21df41308ad9402a032d5d1138cfd7514de Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Apr 08 2020 21:38:02 +0000 Subject: Set directories created for OSTree refs to be group writable We need to set the umask to be more permissive so directories get group write permissions. See https://pagure.io/releng/issue/8811#comment-629051. Signed-off-by: Dusty Mabe --- diff --git a/robosignatory/work.py b/robosignatory/work.py index da3f2be..b6a7f83 100644 --- a/robosignatory/work.py +++ b/robosignatory/work.py @@ -50,7 +50,13 @@ def process_atomic(signer, ref, commitid, key, directory, doref=True): dirname_refpath = os.path.dirname(refpath) if doref and not os.path.exists(dirname_refpath): log.info("Creating the directories for the refpath") - os.makedirs(dirname_refpath) + # Set the umask to be more permissive so directories get group write + # permissions. See https://pagure.io/releng/issue/8811#comment-629051 + oldumask = os.umask(0o0002) + try: + os.makedirs(dirname_refpath) + finally: + os.umask(oldumask) if doref: log.info('Writing %s to %s' % (commitid, refpath))