rpkg

#185 Does it need to backup and restore build_client and kojiconfig in container_build_koji?
Closed: Fixed Opened by cqi.

Closed: Fixed
Reopen Issue

From line 2556, build_client and kojiconfig is backed up and then restored after the build. However, it looks it's not necessary to do this. I think I need some background of it, does anyone know why the code does in this way? If it's unnecessary indeed, those lines of code could be removed.

@pbabinca: do you remember why this is there?

No, I do not. Maybe @jluza knows? It seems to be his code.

I think I know the reason. There could be kojiconfig in section [app name].container-build for container-build command specifically. If there is, container_build_koji will use this option instead of the one in default section to load Koji configuration.

Metadata Update from @cqi:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.