rpkg

#683 pre-push-check prevents pushing to an arbitrarily named branch
Closed: Fixed by onosek. Opened by nforro.

Closed: Fixed
Reopen Issue

Let's say in my dist-git repo I have a branch called private-branch:

$ fedpkg switch-branch private-branch
Switched to branch 'private-branch'
$ git status 
On branch private-branch
Your branch is up to date with 'origin/private-branch'.
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        new file:   test
$ fedpkg commit -m test
[private-branch 6ed1c20] test
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 test
$ fedpkg push
Could not execute pre_push_check: Could not find the release/dist from branch name private-branch
Please specify with --release
error: failed to push some refs to 'ssh://pkgs.fedoraproject.org/rpms/XXX'
Could not execute push: Failed to execute command.
$ fedpkg --release rawhide push
Could not execute pre_push_check: Could not find the release/dist from branch name private-branch
Please specify with --release
error: failed to push some refs to 'ssh://pkgs.fedoraproject.org/rpms/XXX'
Could not execute push: Failed to execute command.

This issue breaks the traditional pull request workflow where people name their branches based on features, push them to forks and propose to upstream [dist-git] branches that have strict naming. Workaround exists with the --no-verify option, it would still be amazing to have this fixed asap to have that pull request workflow working by default in Fedora, so all contributors have solid experience.

Just came here to report the same. Trying to push https://src.fedoraproject.org/rpms/python-click/pull-request/20 resulted in:

[python-click (pytest7.3.0 %)]$ git push -u churchyard pytest7.3.0 
Could not execute pre_push_check: Could not find the release/dist from branch name pytest7.3.0
Please specify with --release
error: failed to push some refs to 'ssh://pkgs.fedoraproject.org/forks/churchyard/rpms/python-click.git'

I was wondering why this started to happen today for me and why it worked previously. I realized that it only worked for repositories I have cloned with the previous fedpkg version. The failure started happening when I cloned new repos.

Commit 4553da36 fixes this issue

Metadata Update from @onosek:
- Issue set to the milestone: 1.67

I’m leaving this note here just so we don’t lose track of the thread, but it seems to me that fix commit 4553da3 is not the correct one. What we should be checking is whether we can’t find a namespace that is valid; only in that case should we fail validation, and not simply when we encounter an error.
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.