rpkg

#79 rpkg srpm , should not write content if Server returned status code 404
Closed: Fixed Opened by sergiomb.

Closed: Fixed
Reopen Issue

As state in https://pagure.io/rpkg/issue/78 if by mistake I use fedpkg srpm instead rfpkg srpm on a package that is not in Fedora repos , etc , we got something like:

Downloading foo.tgz

################################################################## 100.0%

Could not execute srpm: Server returned status code 404

but foo.tgz is written on disk and his content is something like:

`<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

404 Not Found

Not Found

The requested URL /repo/pkgs/rpms/kernel/linux-4.7.tar.xz/5276563eb1f39a048e4a8a887408c031/linux-4.7.tar.xz was not found on this server.

(...)` I think we should avoid write false source code files , It will avoid many confusion. Other note , just in case of http 40x and 50x errors , maybe we should permit other http codes like 30x

At this moment, I think only 200 should be accepted, and the downloaded file containing invalid content should be removed.
Edited by cqi

@cqi changed the status to Fixed
Metadata

RFE

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.