rpkg

#611 contaner-build does not check for existence of kojisession.buildContainer
Merged by onosek. Opened by drumian.
drumian/rpkg RPC_check_removed  into  master

Download 611.patch

When 'container-build' subcommand is used, there was a check for existence
of kojisession.buildContainer RPC. This is not necessary because when there
is some RPC missing the koji.GenericError is returned and a apropriate error
message is printed. Deleting this check will improve performance and lowers
load on the Koji hub.

Jira: RHELCMP-3799
Fixes: https://pagure.io/rpkg/issue/532

Signed-off-by: Dominik Rumian drumian@redhat.com

It is not so obvious, but this row is related to your change too:
tests/test_flatpak_build.py:238

session.system.listMethods.return_value = ['buildContainer']

It can be removed.

It is not so obvious, but this row is related to your change too:
tests/test_flatpak_build.py:238
~~~~~
session.system.listMethods.return_value = ['buildContainer']
~~~~~
It can be removed.
Thank you, I will look at this.

rebased onto d4a4510c1b79708b038a755d299f45ec2dfadd70

rebased onto 10ab02a9c4f77c761a5878be2e9701c6ae3de318

rebased onto 0148596f751baa4107a291f31f1038215ef23526

Pull-Request has been merged by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.