#653 Use srpm when scratch-building from dirty repo
Merged by onosek. Opened by oturpe.
oturpe/rpkg scratch-build-srpm  into  master

Download 653.patch

The most common use case for scratch builds is to test local changes before pushing them.
Unfortunately, the defaults options in the scratch-build command did not support this case.
Instead, an error was printed about uncommitted changes.
To support the common case, scratch-build is changed to generate an srpm from local changes when they are detected.
This way, the original behaviour is retained, and additionally the common case can be supported.

This has been discussed in a Fedora devel mailing list thread.

Fixes #652

Thanks for the effort and code.
I just did some minor changes related to conflicts with your previous PR #649

Commit 4b79a51d fixes this pull-request

Pull-Request has been merged by onosek

Hi, thank you for this feature , can we add the same feature when we got one commit that isn't pushed yet ?

  • Could not execute scratch_build: There are unpushed changes in your repo
    Try option --srpm to make scratch build from local changes.

Sounds useful and easy to implement to me. I probably just overlooked this case when I wrote this pull request. If I find some time, I will look into this.

Metadata