From cad270480e27c2d8ede6c6f10d6e66f7e522ab2a Mon Sep 17 00:00:00 2001 From: Maxwell G Date: Jan 02 2023 08:36:42 +0000 Subject: spectool: Fix functions that return True on success The code expects functions to return False on failures. ``` for task, args in tasks: fail = task(*args) if fail: failure = True ``` Fixes: https://pagure.io/rpmdevtools/pull-request/95 --- diff --git a/rpmdev-spectool b/rpmdev-spectool index b70e967..b97f4fc 100755 --- a/rpmdev-spectool +++ b/rpmdev-spectool @@ -386,10 +386,10 @@ class Spec: try: self._get_file(value, directory, force, dry) - return True + return False except IOError: - return False + return True def get_patch(self, number: int, directory: str, force: bool, dry: bool, value: str = None): if not value: @@ -397,10 +397,10 @@ class Spec: try: self._get_file(value, directory, force, dry) - return True + return False except IOError: - return False + return True def get_sources(self, directory: str, force: bool, dry: bool): failure = False