From 3cf6e2a7e5d237ad0b04acc880383337144e721c Mon Sep 17 00:00:00 2001
From: Tim Landscheidt <tim@tim-landscheidt.de>
Date: Apr 02 2025 13:03:25 +0000
Subject: Fix ShellCheck warnings for rpmdev-packager


---

diff --git a/rpmdev-packager b/rpmdev-packager
index a5140b2..b5c00ae 100755
--- a/rpmdev-packager
+++ b/rpmdev-packager
@@ -78,7 +78,7 @@ while [ -n "$1" ] ; do
 done
 
 username="$( id -un )"
-fullname="$( getent passwd $username 2>/dev/null | cut -d: -f5 )"
+fullname="$( getent passwd "$username" 2>/dev/null | cut -d: -f5 )"
 fullname="${fullname%%,*}"
 # TODO obsolete, should use kerberos instead? e.g.
 #   https://pagure.io/rpkg/blob/master/f/pyrpkg/__init__.py#_823
@@ -94,10 +94,10 @@ packager="$RPM_PACKAGER"
 
 # Try packager certificates
 if [ -z "$packager" ] ; then
-    for cert in $certs ; do
+    for cert in "${certs[@]}" ; do
         if [ -f "$cert" ] ; then
             packager="$( openssl x509 -noout -email -in "$cert" 2>/dev/null )"
-            [ -n "$packager" -a -n "$fullname" ] && \
+            [ -n "$packager" ] && [ -n "$fullname" ] && \
                 packager="$fullname <$packager>"
             [ -n "$packager" ] && break
         fi
@@ -117,7 +117,7 @@ fi
 # Try $MAILTO
 if [ -z "$packager" ] ; then
     packager="$MAILTO"
-    [ -n "$packager" -a -n "$fullname" ] && packager="$fullname <$packager>"
+    [ -n "$packager" ] && [ -n "$fullname" ] && packager="$fullname <$packager>"
 fi
 
 # Try full name