#28 Fix some of compiler warnings
Merged by abbra. Opened by slev.
slev/slapi-nis fix_some_warnings  into  master

Download 28.patch

This is just a fix for some of the annoying compiler warnings.

rebased onto 982dc8c0628264a9211a923ed5b29164dad38d6f

I'm not sure this is correct way -- we probably need to touch the structure but I haven't completed yet reviewing what happens with specific auth mechanisms, is there a side-effect in getting the position. Perhaps, doing (void) xdr_getpos(..) would be enough here?

If we link with tirpc, then
tirpc/rpc/xdr.h

#define xdr_getpos(xdrs)                                \                       
        (*(xdrs)->x_ops->x_getpostn)(xdrs) 

src/xdr_sizeof.c

static u_int                                                                    
x_getpostn(xdrs)                                                                
        XDR *xdrs;                                                              
{                                                                               
        return (xdrs->x_handy);                                                 
} 

There is no side effect.
But you are right, (void) is enough. The decision is up to you.

Could you please update with (void)?

rebased onto a8881e4cbb006fd317ecf89f006747c4dd1c84a4

Yeah, sure.

Pull-Request has been merged by abbra

Metadata