Why here now we have static while in src/back-sch.c we don't have static? Both plugins link against the same src/back-shr.c which calls backend_entry_get_set_config_entry_filter(). If you'd do it static here, that call linkage would be broken.

space/tab mix compared to the next line?

Hi @tbordaz, thank you for the PR. I have left few comments inline.

Thanks @abbra for the review. I have updated the files for spaces/tab and also for the nis function backend_entry_get_set_config_entry_filter that should not be static

@tbordaz thank you for the changes. I have only one question left -- in the task allocation functions for both nis and slapi plugins we don't do checks for strdup failures. Should we?

Failure of strdup (aka slapi_ch_strdup) should not really happen. Else meaning that all virtual space has been consumed and then we can anticipate many others failures.
Checking the duplicate strings are not NULL is good, to prevent a task running with dummy args. I updated the patch. Thanks

Merged, thanks. However, I had to fix few issues:

• use of 389-ds' private function int slapi_td_set_dn(char *dn);, I had to define it with extern modifier in slapi-nis code;
• backend_entry_get_set_config_entry_filter helper implementation had inconsistent signature and was not declared in back-shr.h as it should. I had to fix that.