result running inspekt:
# inspekt indent inventory/standard-inventory-docker Indentation check PASS # inspekt lint inventory/standard-inventory-docker Pylint disabled: W,R,C,E1002,E1101,E1103,E1120,F0401,I0011 Pylint enabled : W0611 Using config file /dev/null Syntax check PASS # inspekt style inventory/standard-inventory-docker PEP8 disabled: E501,E265,W601,E402 PEP8 compliance check PASS
@astepano should we also add license to the file?
Yes, I would do this too. Something like Avocado team do:
https://github.com/avocado-framework/avocado/blob/master/avocado/core/
Put appropriate license.
rebased onto 3d563d6d3eb9f3e88c4c512f7670fb30c108540f
# inspekt license inventory/standard-inventory-docker License check PASS
Copyright (c) 2017-2018 Red Hat Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. Authors: Merlin Mathesius <merlinm@redhat.com> Bruno Goncalves <bgoncalv@redhat.com>
Please take this code as an example. Thank you.
rebased onto ef56aab29cc12ee8c82b48f68655713a35b0285f
Thanks for the example. I've added The MIT License (MIT), because I wanted to make clear we are using MIT license...
The MIT License (MIT)
Commit 2e5da701 fixes this pull-request
Pull-Request has been merged by astepano
result running inspekt:
@astepano should we also add license to the file?