standard-test-roles

#26 inventory: Enable containers and VMs to be diagnosed by setting TEST_DEBUG environment variable
Merged by merlinm. Opened by merlinm.
Unknown source master

Download 26.patch

The inventory scripts do a very good job of cleaning up the containers and VMs when finished. Too good, in fact--which made it impossible to diagnose things going wrong inside the containers/VMs. With this PR, when the playbook finishes, if environment variable TEST_DIAGNOSE_INVENTORY is set to a true value, the inventory scripts will send diagnostic information to stderr and wait for an explicit signal before cleaning up.

For example:

...
TASK [standard-test-beakerlib : Check the results] ************************************************************************************************
changed: [/home/merlinm/Fedora-Atomic-26-20170707.1.x86_64.qcow2]
PLAY RECAP ****************************************************************************************************************************************
/home/merlinm/Fedora-Atomic-26-20170707.1.x86_64.qcow2 : ok=25   changed=13   unreachable=0    failed=0   
$ 
DIAGNOSE: ssh -p 2222 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@127.0.0.3 # password: foobar
DIAGNOSE: kill 5438 # when finished
$ ssh -p 2222 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null root@127.0.0.3
Warning: Permanently added '[127.0.0.3]:2222' (ECDSA) to the list of known hosts.
root@127.0.0.3's password: 
[root@localhost ~]# 
...
[root@localhost ~]# exit
$ sudo kill 5438
DIAGNOSE ending...
qemu-system-x86_64: terminating on signal 15 from pid 5438

...
PLAY RECAP ****************************************************************************************************************************************
d683e25ad3b1d11a0a9752efa5013935c195ed9949380824d5cdf326afb89970 : ok=35   changed=24   unreachable=0    failed=1   
$ 
DIAGNOSE: docker exec -it d683e25ad3b1d11a0a9752efa5013935c195ed9949380824d5cdf326afb89970 /bin/bash
DIAGNOSE: kill 17558 # when finished
$ docker exec -it d683e25ad3b1d11a0a9752efa5013935c195ed9949380824d5cdf326afb89970 /bin/bash
[root@d683e25ad3b1 /]# 
...
[root@d683e25ad3b1 /]# exit
$ sudo kill 17558
DIAGNOSE ending...

I like this in principle, but I'd prefer a larger knob ... which will become the go to for developers/maintainers/testers writing and debugging tests.

What do you think about a $TEST_DEBUG or $TEST_DIAGNOSE variable that turns on this, and later other more verbose diagnostics?

1 new commit added

  • inventory: rename environment variable to trigger container/VM diagnosis from TEST_DIAGNOSE_INVENTORY to TEST_DEBUG

Looks good to me.

Pull-Request has been merged by merlinm
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.