#297 standard-test-beakerlib: Move beakerlib bash scripts to own file
Closed by astepano. Opened by ssahani.
ssahani/standard-test-roles str-scripts  into  master

Download 297.patch

see https://pagure.io/standard-test-roles/issue/286

rebased onto 7a59ec2a8aed01fe8bddcaaf5232d390a6760d0b

rebased onto e8b08ada9da3e993abbc83ffd452af15f0703c1f

/usr/bin/beakerlib-test.sh

where this path comes from?

/usr/bin/beakerlib-test.sh

where this path comes from?

It's copied to
/usr/bin like others see main.yml

we shouldn't copy files from to /usr/bin/

These files are not packaged and it might cause conflicts, or unexpected behaviour of a test.

You can use script module instead, it does the same thing internally: copies the script from localhost to the target machine and runs it, but it uses ansible's temporary folders to perform this task, and doesn't interfere with system files.

rebased onto f0efc96f25191a5371dcdcb61d0a156aed8230ff

updated PTAL

Why do use this form of shebang?
It make sense for python but, even now for python it is deprecated and not recommended form.

I would put here some information. Like: purpose of this script, where it is used. Input required/expected values. Output value. Exit code. Files that are produced.

Is there a way to drop relative path? Does Ansible support it?

None I know of

It's nothing doing something new . Just separates from the embedded ansible code. Feel free to suggest.

rebased onto 162d9aeb589a868e9bafcea73924834b220c643a

Pull-Request has been closed by astepano

Metadata