task-abicheck

#15 Don't perform ABI comparison when package doesn't ship devel or header sub-package
Merged by frantisekz. Opened by sinnykumari.
sinnykumari/task-abicheck develop  into  develop

Download 15.patch

Don't perform ABI comparison when there is no header/devel package
shipped with package. We consider that if there is no header/devel
package is shipped then package doesn't export any public ABI.

This will help to get rid of some false positives ABI changes
See https://pagure.io/task-abicheck/issue/8#comment-502435

Signed-off-by: Sinny Kumari sinny@redhat.com

rebased onto a331fc0764484657992d6e3194f7ebee6a20fd18

If you wish, you can also add:

detail.note = 'no public ABI'

or something like that.

I haven't tested it, but the code looks OK to me. Please merge to develop and let's see if it works.

rebased onto ed94f69c91e77033457cc34c0b6e2ccc3ba7818b

Thanks @kparal for the review, added note as well.

Pull-Request has been merged by frantisekz

Well, I've merged this by an accident :) . If you want to do any changes, feel free to commit them.

No problem, I was just waiting for @dodji to review it as well. But we are good, will fire another PR if we need to do any additional change.

It looks OK to me too, many thanks!

If everything seems to work on dev (it doesn't crash, I haven't dug deeper), please don't forget to merge to master.

Looked into abicheck run on taskotron-dev instance, looks good to me. Merged commit to master
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.