taskotron / taskotron-trigger

#56 critpath: make config value optional
Merged by kparal. Opened by kparal.
feature/critpath_better  into  develop

Download 56.patch

This allows administrators to disable critpath checking by simply not
pointing trigger to any critpath file (the default behavior after this
patch). The job triggers will receive an empty critpath list set in this
case. If a critpath file is set in the config file, the file has to
exist and be valid.

This improves reliability over the previous change in e67e56745ac.

Fixes #54

Please note this hasn't been tested.

Note: When this gets released, a trigger config file in ansible must be adjusted at the very same time this is deployed to our infra servers.

Somewhat better now, thx.

LGTM, if the =E2=80=9Ccritpath_filepath=3D=E2=80=9C with empty value works a=
s expected (can=E2=80=99t check now, as I=E2=80=99m only on a phone).=

Seems to work fine on dev, I'll merge this and we'll create a new release.

Commit abb2e08c fixes this pull-request

Pull-Request has been merged by kparal
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.