PR#216: Add item and type arguments, deprecate subject -

waiverdb

#216 Add item and type arguments, deprecate subject

Merged Jul 23, 2018 by lholecek. Opened Jul 17, 2018 by lholecek.

lholecek/waiverdb cli-subject-item-type into master

lholecek commented Jul 17, 2018

Fixes #213

gnaponie commented Jul 17, 2018

We wanted to deprecate the result-id as a parameter, it is there only for backwards compatibility so I think we shouldn't advice to provide a result-id. I would just advice to use the subject_identifier. Also is it confusing to call it id_?

gnaponie commented Jul 17, 2018

beside that comment it looks ok to me

lholecek commented Jul 17, 2018

OK, I fixed the error message and renamed the new arguments to --subject-identifier and --subject-type.

rebased onto 3349cc7ed354ed106dceebfdcded6a5b68e2344d

Jul 17, 2018

gnaponie commented Jul 17, 2018

lholecek commented Jul 23, 2018

Commit 39c539a8 fixes this pull-request

Pull-Request has been merged by lholecek

Jul 23, 2018

Pull-Request has been merged by lholecek

Jul 23, 2018

Metadata

Assignee

None

Tags

No Tags

waiverdb

#216 Add item and type arguments, deprecate subject Merged Jul 23, 2018 by lholecek. Opened Jul 17, 2018 by lholecek. lholecek/waiverdb cli-subject-item-type into master

Metadata

#216 Add item and type arguments, deprecate subject

Merged Jul 23, 2018 by lholecek. Opened Jul 17, 2018 by lholecek.

lholecek/waiverdb cli-subject-item-type into master