waiverdb

#237 CI/CD - Updating Pagure PR status and sending an email after build completes
Merged by rayson. Opened by rayson.
rayson/waiverdb cicd-post-notifications  into  master

Download 237.patch

This is ported from the existing Jenkinsfile, depending on PR #234.

2 new commits added

  • CI/CD - Updating Pagure PR status and sending an email after build completes
  • CI/CD: add C3I jobs to poll for master branch and PRs on Pagure

rebased onto 67d2b00249647c448e9cb47149d1271448348bce

afaik, this is a configuration setting, called 'Safe HTML' or something like that.

This variable name doesn't really match the actual usage.

post has many conditions besides always. I think much of the logic in this script block could be replaced with those.

And iirc those conditions were more reliable then working with the build result in currentBuild.

@csomh if we split them into different post conditions, there will be some code duplicates. Do you think it is time to introduce a shared library or external script file at this stage?

Either one of those, or a groovy function defined before the pipeline. I don't really have a preference at the moment.

@csomh OK, I will make a function and see if it works.

I added a class to handle PagureAPI communications in the Jenkins.

rebased onto 467b81f7144a9fdce053ab96d535ff3b056a1794

rebased onto 8bb1618d0098f4df83de1f56ed24b57e4af321db

rebased onto dd6399bc92e03f3cd1c41242b7acdd4e5b1a077c

It seems to me, that there is still some code duplication between post.success and post.failure. Would it be possible to get rid of it?

rebased onto 9fc030daa7817dc23d7a0d66d82275c701e8ed07

rebased onto 0533a7f8038eec06e430f8e3d0f54c7a7ea51d9d

@csomh I've updated the PR, please take another look. Thanks.

rebased onto 76c9f608ae3194389c85e296826a59ac71a45f74

+1 Nice!

Can anyone give another review?

It looks ok to me +1

Commit 32ee0d0b fixes this pull-request

Pull-Request has been merged by rayson

Pull-Request has been merged by rayson
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.