waiverdb-trigger-on-latest-tag
waiverdb-trigger-on-stage-tag
@mikeb PTAL
rebased onto 346079d9cbbb14199bd828f7855b1309a6089346
Should be TRACKED_TAG_REGEX
TRACKED_TAG_REGEX
The action and tag checks could all be moved into the selector, which is more efficient than message checks. Something like:
action
tag
selector
selector: "repo='${params.TRACKED_CONTAINER_REPO}' AND action IN ('added', 'updated') AND tag LIKE '${params.TRACKED_TAG_REGEX}'"
Does this really need to be a regex? It might be simpler to just make this a string that's matched against.
The action and tag checks could all be moved into the selector, which is more efficient than message checks. Something like: selector: "repo='${params.TRACKED_CONTAINER_REPO}' AND action IN ('added', 'updated') AND tag LIKE '${params.TRACKED_TAG_REGEX}'"
Sounds good. Regex is used because in the existing job checks for updates of 2 tags. Since we are going to split into 2 jobs, each job should focus only on one tag.
Does this really need to be a regex? It might be simpler to just make this a string that's matched against. Regex is not needed because each new job focuses only on one tag.
rebased onto 3f0d0d8501039446dfb0deacd96cb8808d1bb1a2
+1 This looks great!
Commit 5f84e1e0 fixes this pull-request
Pull-Request has been merged by mikeb
waiverdb-trigger-on-latest-tagandwaiverdb-trigger-on-stage-tag. (Following the practice of #284)@mikeb PTAL